Re: Suggested patch for IdIcmpClient unit

Giganews Newsgroups
Subject: Re: Suggested patch for IdIcmpClient unit
Posted by:  Remy Lebeau \(Indy Team\) (no.spam@no.spam.com)
Date: Wed, 25 Apr 2007

"Pibì" <nospam@tiscali.it> wrote in message
news:49ECED69B323E340nospam@tiscali.it...

> Problem solved:

What is the problem you are trying to solve?  You never explained
that.  I'm not going to make such changes to TIdIcmpClient until you
explain the logic behind it first.

>    SetLength(FbufIcmp, 12 + FPacketSize);        //is
Id_ICMP_MASK_HSIZE?
>    if IPVersion = Id_IPv4 then begin
>      SetLength(FbufReceive, FPacketSize + 32);  // need constant

Why are you adding extra bytes to the outbound buffer?

>          BytesReceived := BytesRead - 32;        // need constant

Why are you removing bytes from the inbound buffer?

Gambit

Replies

In response to

Suggested patch for IdIcmpClient unit posted by Pibì on Wed, 25 Apr 2007